OSDN Git Service

crypto: axis - no need to check return value of debugfs_create functions
authorGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 22 Jan 2019 15:14:18 +0000 (16:14 +0100)
committerHerbert Xu <herbert@gondor.apana.org.au>
Fri, 1 Feb 2019 06:42:03 +0000 (14:42 +0800)
When calling debugfs functions, there is no need to ever check the
return value.  The function can work or not, but the code logic should
never do something different based on this.

Cc: Jesper Nilsson <jesper.nilsson@axis.com>
Cc: Lars Persson <lars.persson@axis.com>
Cc: Herbert Xu <herbert@gondor.apana.org.au>
Cc: "David S. Miller" <davem@davemloft.net>
Cc: linux-arm-kernel@axis.com
Cc: linux-crypto@vger.kernel.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Acked-by: Lars Persson <lars.persson@axis.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
drivers/crypto/axis/artpec6_crypto.c

index f3442c2..1a1858c 100644 (file)
@@ -2984,12 +2984,6 @@ static void artpec6_crypto_init_debugfs(void)
 {
        dbgfs_root = debugfs_create_dir("artpec6_crypto", NULL);
 
-       if (!dbgfs_root || IS_ERR(dbgfs_root)) {
-               dbgfs_root = NULL;
-               pr_err("%s: Could not initialise debugfs!\n", MODULE_NAME);
-               return;
-       }
-
 #ifdef CONFIG_FAULT_INJECTION
        fault_create_debugfs_attr("fail_status_read", dbgfs_root,
                                  &artpec6_crypto_fail_status_read);
@@ -3001,9 +2995,6 @@ static void artpec6_crypto_init_debugfs(void)
 
 static void artpec6_crypto_free_debugfs(void)
 {
-       if (!dbgfs_root)
-               return;
-
        debugfs_remove_recursive(dbgfs_root);
        dbgfs_root = NULL;
 }