OSDN Git Service

staging: rtl8188eu: reduce indentation level in _rtw_free_sta_priv
authorMichael Straube <straube.linux@gmail.com>
Sun, 27 Oct 2019 13:06:02 +0000 (14:06 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 28 Oct 2019 15:40:25 +0000 (16:40 +0100)
Reduce indentation level in _rtw_free_sta_priv by returning early if
pstapriv is NULL. Also clears a line over 80 characters checkpatch
warning.

Signed-off-by: Michael Straube <straube.linux@gmail.com>
Link: https://lore.kernel.org/r/20191027130604.68379-2-straube.linux@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/rtl8188eu/core/rtw_sta_mgt.c

index 65a824b..6c03068 100644 (file)
@@ -135,31 +135,30 @@ u32 _rtw_free_sta_priv(struct sta_priv *pstapriv)
        struct recv_reorder_ctrl *preorder_ctrl;
        int index;
 
-       if (pstapriv) {
-               /* delete all reordering_ctrl_timer */
-               spin_lock_bh(&pstapriv->sta_hash_lock);
-               for (index = 0; index < NUM_STA; index++) {
-                       phead = &pstapriv->sta_hash[index];
-                       plist = phead->next;
-
-                       while (phead != plist) {
-                               int i;
-
-                               psta = container_of(plist, struct sta_info,
-                                                   hash_list);
-                               plist = plist->next;
-
-                               for (i = 0; i < 16; i++) {
-                                       preorder_ctrl = &psta->recvreorder_ctrl[i];
-                                       del_timer_sync(&preorder_ctrl->reordering_ctrl_timer);
-                               }
+       if (!pstapriv)
+               return _SUCCESS;
+
+       /* delete all reordering_ctrl_timer */
+       spin_lock_bh(&pstapriv->sta_hash_lock);
+       for (index = 0; index < NUM_STA; index++) {
+               phead = &pstapriv->sta_hash[index];
+               plist = phead->next;
+
+               while (phead != plist) {
+                       int i;
+
+                       psta = container_of(plist, struct sta_info, hash_list);
+                       plist = plist->next;
+
+                       for (i = 0; i < 16; i++) {
+                               preorder_ctrl = &psta->recvreorder_ctrl[i];
+                               del_timer_sync(&preorder_ctrl->reordering_ctrl_timer);
                        }
                }
-               spin_unlock_bh(&pstapriv->sta_hash_lock);
-               /*===============================*/
-
-               vfree(pstapriv->pallocated_stainfo_buf);
        }
+       spin_unlock_bh(&pstapriv->sta_hash_lock);
+
+       vfree(pstapriv->pallocated_stainfo_buf);
 
        return _SUCCESS;
 }