OSDN Git Service

net: ethernet: mediatek: fix a typo bug in flow offloading
authorDENG Qingfang <dqfext@gmail.com>
Sat, 17 Apr 2021 07:29:04 +0000 (15:29 +0800)
committerDavid S. Miller <davem@davemloft.net>
Mon, 19 Apr 2021 22:39:52 +0000 (15:39 -0700)
Issue was traffic problems after a while with increased ping times if
flow offload is active. It turns out that key_offset with cookie is
needed in rhashtable_params but was re-assigned to head_offset.
Fix the assignment.

Fixes: 502e84e2382d ("net: ethernet: mtk_eth_soc: add flow offloading support")
Signed-off-by: DENG Qingfang <dqfext@gmail.com>
Tested-by: Frank Wunderlich <frank-w@public-files.de>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/mediatek/mtk_ppe_offload.c

index 4975106..f47f319 100644 (file)
@@ -43,7 +43,7 @@ struct mtk_flow_entry {
 
 static const struct rhashtable_params mtk_flow_ht_params = {
        .head_offset = offsetof(struct mtk_flow_entry, node),
-       .head_offset = offsetof(struct mtk_flow_entry, cookie),
+       .key_offset = offsetof(struct mtk_flow_entry, cookie),
        .key_len = sizeof(unsigned long),
        .automatic_shrinking = true,
 };