OSDN Git Service

igc: Remove obsolete IGC_ERR define
authorSasha Neftin <sasha.neftin@intel.com>
Mon, 12 Nov 2018 09:05:20 +0000 (11:05 +0200)
committerJeff Kirsher <jeffrey.t.kirsher@intel.com>
Wed, 21 Nov 2018 18:55:06 +0000 (10:55 -0800)
Address community comment.
Remove obsolete IGC_ERR define and use dev_err method.
Suggested by Joe Perches.

Signed-off-by: Sasha Neftin <sasha.neftin@intel.com>
Tested-by: Aaron Brown <aaron.f.brown@intel.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
drivers/net/ethernet/intel/igc/igc.h
drivers/net/ethernet/intel/igc/igc_main.c

index 3b00b10..b1039dd 100644 (file)
@@ -11,8 +11,6 @@
 #include <linux/ethtool.h>
 #include <linux/sctp.h>
 
-#define IGC_ERR(args...) pr_err("igc: " args)
-
 #include "igc_hw.h"
 
 /* main */
index 28ffe98..f201830 100644 (file)
@@ -3535,7 +3535,7 @@ static int igc_probe(struct pci_dev *pdev,
                        err = dma_set_coherent_mask(&pdev->dev,
                                                    DMA_BIT_MASK(32));
                        if (err) {
-                               IGC_ERR("Wrong DMA configuration, aborting\n");
+                               dev_err(&pdev->dev, "igc: Wrong DMA config\n");
                                goto err_dma;
                        }
                }