OSDN Git Service

drm/i915/dp: Remove debug dependency of DPCD SW/HW revision read
authorImre Deak <imre.deak@intel.com>
Mon, 24 Oct 2016 16:33:25 +0000 (19:33 +0300)
committerImre Deak <imre.deak@intel.com>
Wed, 26 Oct 2016 09:40:59 +0000 (12:40 +0300)
Performing DPCD AUX reads based on debug settings may introduce obscure
bugs in other places that depend on the read being done (or being not
done). To reduce the uncertainty perform the reads unconditionally.

Cc: Mika Kahola <mika.kahola@intel.com>
Suggested-by: Jani Nikula <jani.nikula@intel.com>
Signed-off-by: Imre Deak <imre.deak@intel.com>
Reviewed-by: Jani Nikula <jani.nikula@intel.com>
Link: http://patchwork.freedesktop.org/patch/msgid/1477326811-30431-3-git-send-email-imre.deak@intel.com
drivers/gpu/drm/i915/intel_dp.c

index 951a0bb..5af3907 100644 (file)
@@ -1456,9 +1456,6 @@ static void intel_dp_print_hw_revision(struct intel_dp *intel_dp)
        uint8_t rev;
        int len;
 
-       if ((drm_debug & DRM_UT_KMS) == 0)
-               return;
-
        if (!drm_dp_is_branch(intel_dp->dpcd))
                return;
 
@@ -1474,9 +1471,6 @@ static void intel_dp_print_sw_revision(struct intel_dp *intel_dp)
        uint8_t rev[2];
        int len;
 
-       if ((drm_debug & DRM_UT_KMS) == 0)
-               return;
-
        if (!drm_dp_is_branch(intel_dp->dpcd))
                return;