OSDN Git Service
(root)
/
uclinux-h8
/
linux.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
cf9836f
)
regulator: wm831x_reg_read() failure unnoticed in wm831x_aldo_get_mode()
author
Roel Kluin
<roel.kluin@gmail.com>
Tue, 15 Dec 2009 19:07:31 +0000
(20:07 +0100)
committer
Liam Girdwood
<lrg@slimlogic.co.uk>
Thu, 17 Dec 2009 10:27:30 +0000
(10:27 +0000)
ret should be signed to notice a failure in wm831x_reg_read().
Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
Acked-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
Signed-off-by: Liam Girdwood <lrg@slimlogic.co.uk>
drivers/regulator/wm831x-ldo.c
patch
|
blob
|
history
diff --git
a/drivers/regulator/wm831x-ldo.c
b/drivers/regulator/wm831x-ldo.c
index
902db56
..
61e02ac
100644
(file)
--- a/
drivers/regulator/wm831x-ldo.c
+++ b/
drivers/regulator/wm831x-ldo.c
@@
-470,7
+470,7
@@
static unsigned int wm831x_aldo_get_mode(struct regulator_dev *rdev)
struct wm831x_ldo *ldo = rdev_get_drvdata(rdev);
struct wm831x *wm831x = ldo->wm831x;
int on_reg = ldo->base + WM831X_LDO_ON_CONTROL;
-
unsigned
int ret;
+ int ret;
ret = wm831x_reg_read(wm831x, on_reg);
if (ret < 0)