OSDN Git Service

ice: use devm_kcalloc() instead of devm_kzalloc()
authorGustavo A. R. Silva <gustavoars@kernel.org>
Wed, 6 Oct 2021 18:09:08 +0000 (13:09 -0500)
committerTony Nguyen <anthony.l.nguyen@intel.com>
Tue, 19 Oct 2021 17:53:28 +0000 (10:53 -0700)
Use 2-factor multiplication argument form devm_kcalloc() instead
of devm_kzalloc().

Link: https://github.com/KSPP/linux/issues/162
Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
Signed-off-by: Tony Nguyen <anthony.l.nguyen@intel.com>
drivers/net/ethernet/intel/ice/ice_ethtool_fdir.c
drivers/net/ethernet/intel/ice/ice_txrx.c

index 16de603..38960bc 100644 (file)
@@ -706,7 +706,7 @@ ice_create_init_fdir_rule(struct ice_pf *pf, enum ice_fltr_ptype flow)
        if (!seg)
                return -ENOMEM;
 
-       tun_seg = devm_kzalloc(dev, sizeof(*seg) * ICE_FD_HW_SEG_MAX,
+       tun_seg = devm_kcalloc(dev, sizeof(*seg), ICE_FD_HW_SEG_MAX,
                               GFP_KERNEL);
        if (!tun_seg) {
                devm_kfree(dev, seg);
@@ -1068,7 +1068,7 @@ ice_cfg_fdir_xtrct_seq(struct ice_pf *pf, struct ethtool_rx_flow_spec *fsp,
        if (!seg)
                return -ENOMEM;
 
-       tun_seg = devm_kzalloc(dev, sizeof(*seg) * ICE_FD_HW_SEG_MAX,
+       tun_seg = devm_kcalloc(dev, sizeof(*seg), ICE_FD_HW_SEG_MAX,
                               GFP_KERNEL);
        if (!tun_seg) {
                devm_kfree(dev, seg);
index 8f908af..bc3ba19 100644 (file)
@@ -343,7 +343,7 @@ int ice_setup_tx_ring(struct ice_tx_ring *tx_ring)
        /* warn if we are about to overwrite the pointer */
        WARN_ON(tx_ring->tx_buf);
        tx_ring->tx_buf =
-               devm_kzalloc(dev, sizeof(*tx_ring->tx_buf) * tx_ring->count,
+               devm_kcalloc(dev, sizeof(*tx_ring->tx_buf), tx_ring->count,
                             GFP_KERNEL);
        if (!tx_ring->tx_buf)
                return -ENOMEM;
@@ -475,7 +475,7 @@ int ice_setup_rx_ring(struct ice_rx_ring *rx_ring)
        /* warn if we are about to overwrite the pointer */
        WARN_ON(rx_ring->rx_buf);
        rx_ring->rx_buf =
-               devm_kzalloc(dev, sizeof(*rx_ring->rx_buf) * rx_ring->count,
+               devm_kcalloc(dev, sizeof(*rx_ring->rx_buf), rx_ring->count,
                             GFP_KERNEL);
        if (!rx_ring->rx_buf)
                return -ENOMEM;