OSDN Git Service

scsi: target: Use config_item_name() instead of open-coding it
authorBart Van Assche <bart.vanassche@wdc.com>
Fri, 22 Jun 2018 21:52:48 +0000 (14:52 -0700)
committerMartin K. Petersen <martin.petersen@oracle.com>
Mon, 2 Jul 2018 20:44:30 +0000 (16:44 -0400)
Some target code uses config_item_name() while other code accesses .ci_name
directly. Make the target code consistent by switching to
config_item_name().

Signed-off-by: Bart Van Assche <bart.vanassche@wdc.com>
Reviewed-by: Mike Christie <mchristi@redhat.com>
Cc: Hannes Reinecke <hare@suse.com>
Cc: Christoph Hellwig <hch@lst.de>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/target/target_core_configfs.c
drivers/target/target_core_sbc.c

index 5ccef7d..93d3ff3 100644 (file)
@@ -263,8 +263,8 @@ static struct config_group *target_core_register_fabric(
                        &tf->tf_discovery_cit);
        configfs_add_default_group(&tf->tf_disc_group, &tf->tf_group);
 
-       pr_debug("Target_Core_ConfigFS: REGISTER -> Allocated Fabric:"
-                       " %s\n", tf->tf_group.cg_item.ci_name);
+       pr_debug("Target_Core_ConfigFS: REGISTER -> Allocated Fabric: %s\n",
+                config_item_name(&tf->tf_group.cg_item));
        return &tf->tf_group;
 }
 
index b054682..ebac2b4 100644 (file)
@@ -978,9 +978,10 @@ sbc_parse_cdb(struct se_cmd *cmd, struct sbc_ops *ops)
        }
        case COMPARE_AND_WRITE:
                if (!dev->dev_attrib.emulate_caw) {
-                       pr_err_ratelimited("se_device %s/%s (vpd_unit_serial %s) reject"
-                               " COMPARE_AND_WRITE\n", dev->se_hba->backend->ops->name,
-                               dev->dev_group.cg_item.ci_name, dev->t10_wwn.unit_serial);
+                       pr_err_ratelimited("se_device %s/%s (vpd_unit_serial %s) reject COMPARE_AND_WRITE\n",
+                                          dev->se_hba->backend->ops->name,
+                                          config_item_name(&dev->dev_group.cg_item),
+                                          dev->t10_wwn.unit_serial);
                        return TCM_UNSUPPORTED_SCSI_OPCODE;
                }
                sectors = cdb[13];