OSDN Git Service

greybus: connection: Exit connection before destroying it
authorViresh Kumar <viresh.kumar@linaro.org>
Fri, 3 Jul 2015 11:30:25 +0000 (17:00 +0530)
committerGreg Kroah-Hartman <gregkh@google.com>
Wed, 8 Jul 2015 18:40:53 +0000 (11:40 -0700)
gb_connection_create() can initialize a connection if bundle->device id
is valid. And so the connection must be destroyed by calling
gb_connection_exit() before gb_connection_destroy(). This wasn't done in
the code that is parsing the manifest.

Fix it.

Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@google.com>
drivers/staging/greybus/manifest.c

index ce4e89c..bea565f 100644 (file)
@@ -255,6 +255,7 @@ cleanup:
        /* An error occurred; undo any changes we've made */
        list_for_each_entry_safe(connection, connection_next,
                        &bundle->connections, bundle_links) {
+               gb_connection_exit(connection);
                gb_connection_destroy(connection);
                count--;
        }