OSDN Git Service

Bluetooth: Check scan state before disabling during suspend
authorManish Mandlik <mmandlik@google.com>
Tue, 2 Jun 2020 01:42:51 +0000 (18:42 -0700)
committerMarcel Holtmann <marcel@holtmann.org>
Wed, 3 Jun 2020 17:51:49 +0000 (19:51 +0200)
Check current scan state by checking HCI_LE_SCAN flag and send scan
disable command only if scan is already enabled.

Signed-off-by: Manish Mandlik <mmandlik@google.com>
Reviewed-by: Abhishek Pandit-Subedi <abhishekpandit@chromium.org>
Reviewed-by: Alain Michaud <alainm@chromium.org>
Signed-off-by: Marcel Holtmann <marcel@holtmann.org>
net/bluetooth/hci_request.c

index 1fc5568..1acf5b8 100644 (file)
@@ -998,8 +998,9 @@ static void hci_req_set_event_filter(struct hci_request *req)
 
 static void hci_req_config_le_suspend_scan(struct hci_request *req)
 {
-       /* Can't change params without disabling first */
-       hci_req_add_le_scan_disable(req);
+       /* Before changing params disable scan if enabled */
+       if (hci_dev_test_flag(req->hdev, HCI_LE_SCAN))
+               hci_req_add_le_scan_disable(req);
 
        /* Configure params and enable scanning */
        hci_req_add_le_passive_scan(req);
@@ -1065,8 +1066,9 @@ void hci_req_prepare_suspend(struct hci_dev *hdev, enum suspended_state next)
                page_scan = SCAN_DISABLED;
                hci_req_add(&req, HCI_OP_WRITE_SCAN_ENABLE, 1, &page_scan);
 
-               /* Disable LE passive scan */
-               hci_req_add_le_scan_disable(&req);
+               /* Disable LE passive scan if enabled */
+               if (hci_dev_test_flag(hdev, HCI_LE_SCAN))
+                       hci_req_add_le_scan_disable(&req);
 
                /* Mark task needing completion */
                set_bit(SUSPEND_SCAN_DISABLE, hdev->suspend_tasks);