OSDN Git Service

tty: serial: qcom_geni_serial: simplify getting .driver_data
authorWolfram Sang <wsa+renesas@sang-engineering.com>
Sun, 21 Oct 2018 20:00:59 +0000 (22:00 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 9 Nov 2018 16:58:19 +0000 (08:58 -0800)
We should get 'driver_data' from 'struct device' directly. Going via
platform_device is an unneeded step back and forth.

Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/tty/serial/qcom_geni_serial.c

index 4bf877c..3040998 100644 (file)
@@ -162,8 +162,7 @@ static struct qcom_geni_serial_port qcom_geni_uart_ports[GENI_UART_PORTS] = {
 static ssize_t loopback_show(struct device *dev,
                                struct device_attribute *attr, char *buf)
 {
-       struct platform_device *pdev = to_platform_device(dev);
-       struct qcom_geni_serial_port *port = platform_get_drvdata(pdev);
+       struct qcom_geni_serial_port *port = dev_get_drvdata(dev);
 
        return snprintf(buf, sizeof(u32), "%d\n", port->loopback);
 }
@@ -172,8 +171,7 @@ static ssize_t loopback_store(struct device *dev,
                                struct device_attribute *attr, const char *buf,
                                size_t size)
 {
-       struct platform_device *pdev = to_platform_device(dev);
-       struct qcom_geni_serial_port *port = platform_get_drvdata(pdev);
+       struct qcom_geni_serial_port *port = dev_get_drvdata(dev);
        u32 loopback;
 
        if (kstrtoint(buf, 0, &loopback) || loopback > MAX_LOOPBACK_CFG) {