OSDN Git Service

crypto: hisilicon/hpre - delete redundant log and return in advance
authorHui Tang <tanghui20@huawei.com>
Sat, 10 Apr 2021 09:50:32 +0000 (17:50 +0800)
committerHerbert Xu <herbert@gondor.apana.org.au>
Fri, 16 Apr 2021 11:24:27 +0000 (21:24 +1000)
'hpre_cfg_by_dsm' has checked and printed error path internally. It is not
necessary to do it here, so remove it.

It should return error immediately when return value of 'hpre_cfg_by_dsm'
is non-zero, and no need to execute the remaining sentences.

Signed-off-by: Hui Tang <tanghui20@huawei.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
drivers/crypto/hisilicon/hpre/hpre_main.c

index 2962c33..916af3f 100644 (file)
@@ -384,7 +384,7 @@ static int hpre_set_user_domain_and_cache(struct hisi_qm *qm)
        if (qm->ver == QM_HW_V2) {
                ret = hpre_cfg_by_dsm(qm);
                if (ret)
-                       dev_err(dev, "acpi_evaluate_dsm err.\n");
+                       return ret;
 
                disable_flr_of_bme(qm);
        }