OSDN Git Service

ASoC: cros_ec_codec: fix uninitialized memory read
authorArnd Bergmann <arnd@arndb.de>
Thu, 3 Dec 2020 22:54:41 +0000 (23:54 +0100)
committerMark Brown <broonie@kernel.org>
Fri, 4 Dec 2020 23:26:33 +0000 (23:26 +0000)
gcc points out a memory area that is copied to a device
but not initialized:

sound/soc/codecs/cros_ec_codec.c: In function 'i2s_rx_event':
arch/x86/include/asm/string_32.h:83:20: error: '*((void *)&p+4)' may be used uninitialized in this function [-Werror=maybe-uninitialized]
   83 |   *((int *)to + 1) = *((int *)from + 1);

Initialize all the unused fields to zero.

Fixes: 727f1c71c780 ("ASoC: cros_ec_codec: refactor I2S RX")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Acked-by: Tzung-Bi Shih <tzungbi@google.com>
Link: https://lore.kernel.org/r/20201203225458.1477830-1-arnd@kernel.org
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/codecs/cros_ec_codec.c

index 28f039a..5c3b7e5 100644 (file)
@@ -332,7 +332,7 @@ static int i2s_rx_event(struct snd_soc_dapm_widget *w,
                snd_soc_dapm_to_component(w->dapm);
        struct cros_ec_codec_priv *priv =
                snd_soc_component_get_drvdata(component);
-       struct ec_param_ec_codec_i2s_rx p;
+       struct ec_param_ec_codec_i2s_rx p = {};
 
        switch (event) {
        case SND_SOC_DAPM_PRE_PMU: