OSDN Git Service

sequencer: avoid leaking message buffer when refusing to create an empty commit
authorFelipe Contreras <felipe.contreras@gmail.com>
Thu, 6 Jun 2013 08:58:57 +0000 (03:58 -0500)
committerJunio C Hamano <gitster@pobox.com>
Thu, 6 Jun 2013 18:21:28 +0000 (11:21 -0700)
We should free objects before leaving.

Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
sequencer.c

index b4989ba..f7be7d8 100644 (file)
@@ -628,8 +628,10 @@ static int do_pick_commit(struct commit *commit, struct replay_opts *opts)
        }
 
        allow = allow_empty(opts, commit);
-       if (allow < 0)
-               return allow;
+       if (allow < 0) {
+               res = allow;
+               goto leave;
+       }
        if (!opts->no_commit)
                res = run_git_commit(defmsg, opts, allow);