OSDN Git Service

scsi: lpfc: Remove unnecessary null check before kfree
authorYueHaibing <yuehaibing@huawei.com>
Thu, 11 Jul 2019 14:10:37 +0000 (22:10 +0800)
committerMartin K. Petersen <martin.petersen@oracle.com>
Mon, 22 Jul 2019 20:44:07 +0000 (16:44 -0400)
A null check before a kfree is redundant, so remove it.  This is detected
by coccinelle.

Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Reviewed-by: James Smart <james.smart@broadcom.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/lpfc/lpfc_bsg.c

index b7216d6..c7f6623 100644 (file)
@@ -1276,9 +1276,7 @@ lpfc_bsg_hba_set_event(struct bsg_job *job)
        return 0; /* call job done later */
 
 job_error:
-       if (dd_data != NULL)
-               kfree(dd_data);
-
+       kfree(dd_data);
        job->dd_data = NULL;
        return rc;
 }