OSDN Git Service

media: vsp1: Fix an error handling path in the probe function
authorChristophe JAILLET <christophe.jaillet@wanadoo.fr>
Sat, 12 Dec 2020 17:41:19 +0000 (18:41 +0100)
committerMauro Carvalho Chehab <mchehab+huawei@kernel.org>
Tue, 12 Jan 2021 17:17:03 +0000 (18:17 +0100)
A previous 'rcar_fcp_get()' call must be undone in the error handling path,
as already done in the remove function.

Fixes: 94fcdf829793 ("[media] v4l: vsp1: Add FCP support")
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Reviewed-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
drivers/media/platform/vsp1/vsp1_drv.c

index dc62533..aa66e4f 100644 (file)
@@ -882,8 +882,10 @@ static int vsp1_probe(struct platform_device *pdev)
        }
 
 done:
-       if (ret)
+       if (ret) {
                pm_runtime_disable(&pdev->dev);
+               rcar_fcp_put(vsp1->fcp);
+       }
 
        return ret;
 }