OSDN Git Service

atl1: remove set but not used variable 'advertising'
authorYueHaibing <yuehaibing@huawei.com>
Thu, 20 Sep 2018 02:41:30 +0000 (02:41 +0000)
committerDavid S. Miller <davem@davemloft.net>
Thu, 20 Sep 2018 06:10:07 +0000 (23:10 -0700)
Fixes gcc '-Wunused-but-set-variable' warning:

drivers/net/ethernet/atheros/atlx/atl1.c: In function 'atl1_set_link_ksettings':
drivers/net/ethernet/atheros/atlx/atl1.c:3280:6: warning:
 variable 'advertising' set but not used [-Wunused-but-set-variable]

Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/atheros/atlx/atl1.c

index 72e7fa7..63edc57 100644 (file)
@@ -3277,7 +3277,6 @@ static int atl1_set_link_ksettings(struct net_device *netdev,
        u16 phy_data;
        int ret_val = 0;
        u16 old_media_type = hw->media_type;
-       u32 advertising;
 
        if (netif_running(adapter->netdev)) {
                if (netif_msg_link(adapter))
@@ -3311,25 +3310,7 @@ static int atl1_set_link_ksettings(struct net_device *netdev,
                                hw->media_type = MEDIA_TYPE_10M_HALF;
                }
        }
-       switch (hw->media_type) {
-       case MEDIA_TYPE_AUTO_SENSOR:
-               advertising =
-                   ADVERTISED_10baseT_Half |
-                   ADVERTISED_10baseT_Full |
-                   ADVERTISED_100baseT_Half |
-                   ADVERTISED_100baseT_Full |
-                   ADVERTISED_1000baseT_Full |
-                   ADVERTISED_Autoneg | ADVERTISED_TP;
-               break;
-       case MEDIA_TYPE_1000M_FULL:
-               advertising =
-                   ADVERTISED_1000baseT_Full |
-                   ADVERTISED_Autoneg | ADVERTISED_TP;
-               break;
-       default:
-               advertising = 0;
-               break;
-       }
+
        if (atl1_phy_setup_autoneg_adv(hw)) {
                ret_val = -EINVAL;
                if (netif_msg_link(adapter))