OSDN Git Service

platform/x86: dell-wmi-led: Adjust instance of wmi_evaluate_method calls to 0
authorMario Limonciello <mario.limonciello@dell.com>
Fri, 23 Jun 2017 14:35:21 +0000 (09:35 -0500)
committerDarren Hart (VMware) <dvhart@infradead.org>
Wed, 28 Jun 2017 16:01:36 +0000 (09:01 -0700)
Pali recently noticed that WMI instances are zero indexed.

The only reason that these calls all worked properly is because the ASL
didn't verify the instance number.

Signed-off-by: Louis Davis <louis.davis@dell.com>
Signed-off-by: Mario Limonciello <mario.limonciello@dell.com>
Signed-off-by: Darren Hart (VMware) <dvhart@infradead.org>
drivers/platform/x86/dell-wmi-led.c

index a0c7e99..5bedaf7 100644 (file)
@@ -68,7 +68,7 @@ static int dell_led_perform_fn(u8 length, u8 result_code, u8 device_id,
        input.length = sizeof(struct bios_args);
        input.pointer = &args;
 
-       status = wmi_evaluate_method(DELL_LED_BIOS_GUID, 1, 1, &input, &output);
+       status = wmi_evaluate_method(DELL_LED_BIOS_GUID, 0, 1, &input, &output);
        if (ACPI_FAILURE(status))
                return status;