OSDN Git Service

qede: Use 'skb_add_rx_frag()' instead of hand coding it
authorChristophe JAILLET <christophe.jaillet@wanadoo.fr>
Sun, 4 Apr 2021 12:42:57 +0000 (14:42 +0200)
committerDavid S. Miller <davem@davemloft.net>
Mon, 5 Apr 2021 18:59:33 +0000 (11:59 -0700)
Some lines of code can be merged into an equivalent 'skb_add_rx_frag()'
call which is less verbose.

Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Acked-by: Manish Chopra <manishc@marvell.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/qlogic/qede/qede_fp.c

index ee3e45e..8e150dd 100644 (file)
@@ -1209,12 +1209,9 @@ static int qede_rx_build_jumbo(struct qede_dev *edev,
                dma_unmap_page(rxq->dev, bd->mapping,
                               PAGE_SIZE, DMA_FROM_DEVICE);
 
-               skb_fill_page_desc(skb, skb_shinfo(skb)->nr_frags,
-                                  bd->data, rxq->rx_headroom, cur_size);
+               skb_add_rx_frag(skb, skb_shinfo(skb)->nr_frags, bd->data,
+                               rxq->rx_headroom, cur_size, PAGE_SIZE);
 
-               skb->truesize += PAGE_SIZE;
-               skb->data_len += cur_size;
-               skb->len += cur_size;
                pkt_len -= cur_size;
        }