OSDN Git Service

crypto: hisilicon - fix param should be static when not external.
authorShukun Tan <tanshukun1@huawei.com>
Mon, 21 Oct 2019 07:41:02 +0000 (15:41 +0800)
committerHerbert Xu <herbert@gondor.apana.org.au>
Fri, 25 Oct 2019 15:09:59 +0000 (02:09 +1100)
This patch fixes following sparse warning:
zip_main.c:87:1: warning: symbol 'hisi_zip_list' was not declared.
Should it be static?
zip_main.c:88:1: warning: symbol 'hisi_zip_list_lock' was not declared.
Should it be static?
zip_main.c:948:68: warning: Using plain integer as NULL pointer

Signed-off-by: Shukun Tan <tanshukun1@huawei.com>
Signed-off-by: Zhou Wang <wangzhou1@hisilicon.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
drivers/crypto/hisilicon/zip/zip_main.c

index 5546edc..9f45bb5 100644 (file)
@@ -84,8 +84,8 @@
 
 static const char hisi_zip_name[] = "hisi_zip";
 static struct dentry *hzip_debugfs_root;
-LIST_HEAD(hisi_zip_list);
-DEFINE_MUTEX(hisi_zip_list_lock);
+static LIST_HEAD(hisi_zip_list);
+static DEFINE_MUTEX(hisi_zip_list_lock);
 
 #ifdef CONFIG_NUMA
 static struct hisi_zip *find_zip_device_numa(int node)
@@ -944,7 +944,7 @@ static struct pci_driver hisi_zip_pci_driver = {
        .probe                  = hisi_zip_probe,
        .remove                 = hisi_zip_remove,
        .sriov_configure        = IS_ENABLED(CONFIG_PCI_IOV) ?
-                                       hisi_zip_sriov_configure : 0,
+                                       hisi_zip_sriov_configure : NULL,
        .err_handler            = &hisi_zip_err_handler,
 };