OSDN Git Service

staging: lustre: osc: remove obsolete asserts
authorJinshan Xiong <jinshan.xiong@intel.com>
Sat, 18 Feb 2017 21:47:04 +0000 (16:47 -0500)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 6 Mar 2017 08:16:59 +0000 (09:16 +0100)
Remove the no longer needed assert in the function
osc_cache_truncate_start(). The assertion in
osc_object_prune() will become faulty with upcoming
changes. The reason this will become a problem is
that there may exist freeing pages in object's
radix tree at the time of osc_object_prune(), which
causes failure at the assertion of (osc->oo_npages == 0).
This patch prevents that problem from happening.

Signed-off-by: Jinshan Xiong <jinshan.xiong@intel.com>
Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-6271
Reviewed-on: http://review.whamcloud.com/16456
Reviewed-on: http://review.whamcloud.com/16727
Reviewed-by: Bobi Jam <bobijam@hotmail.com>
Reviewed-by: John L. Hammond <john.hammond@intel.com>
Reviewed-by: James Simmons <uja.ornl@yahoo.com>
Reviewed-by: Oleg Drokin <oleg.drokin@intel.com>
Signed-off-by: James Simmons <jsimmons@infradead.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/lustre/lustre/osc/osc_cache.c
drivers/staging/lustre/lustre/osc/osc_object.c

index 0490478..6445bbe 100644 (file)
@@ -2790,7 +2790,6 @@ again:
                         * We have to wait for this extent because we can't
                         * truncate that page.
                         */
-                       LASSERT(!ext->oe_hp);
                        OSC_EXTENT_DUMP(D_CACHE, ext,
                                        "waiting for busy extent\n");
                        waiting = osc_extent_get(ext);
index d3e5ca7..4f8e78b 100644 (file)
@@ -200,10 +200,6 @@ static int osc_object_prune(const struct lu_env *env, struct cl_object *obj)
        struct osc_object       *osc = cl2osc(obj);
        struct ldlm_res_id      *resname = &osc_env_info(env)->oti_resname;
 
-       LASSERTF(osc->oo_npages == 0,
-                DFID "still have %lu pages, obj: %p, osc: %p\n",
-                PFID(lu_object_fid(&obj->co_lu)), osc->oo_npages, obj, osc);
-
        /* DLM locks don't hold a reference of osc_object so we have to
         * clear it before the object is being destroyed.
         */