OSDN Git Service

staging: comedi: fl512: usleep_range is preferred over udelay
authorH Hartley Sweeten <hsweeten@visionengravers.com>
Wed, 7 Oct 2015 22:43:44 +0000 (15:43 -0700)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 13 Oct 2015 04:26:38 +0000 (21:26 -0700)
Fix checkpatch.pl issue:

CHECK: usleep_range is preferred over udelay; see
       Documentation/timers/timers-howto.txt

Replace the udelay() with usleep_range() with a reasonable upper limit.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/comedi/drivers/fl512.c

index 55cae61..0f278ff 100644 (file)
@@ -71,7 +71,7 @@ static int fl512_ai_insn_read(struct comedi_device *dev,
                outb(0, dev->iobase + FL512_AI_START_CONV_REG);
 
                /* XXX should test "done" flag instead of delay */
-               udelay(30);
+               usleep_range(30, 100);
 
                val = inb(dev->iobase + FL512_AI_LSB_REG);
                val |= (inb(dev->iobase + FL512_AI_MSB_REG) << 8);