OSDN Git Service

[SCSI] sym53c8xx: Remove unnecessary check in queuecommand
authorMatthew Wilcox <matthew@wil.cx>
Fri, 5 Oct 2007 19:55:01 +0000 (15:55 -0400)
committerJames Bottomley <jejb@mulgrave.localdomain>
Tue, 23 Oct 2007 19:09:04 +0000 (15:09 -0400)
The midlayer won't scan the host ID, so we don't need to check.
This is the only caller of sym_xpt_done2, so remove that too.

Signed-off-by: Matthew Wilcox <willy@linux.intel.com>
Signed-off-by: James Bottomley <James.Bottomley@SteelEye.com>
drivers/scsi/sym53c8xx_2/sym_glue.c

index cfce00b..9fc2ae8 100644 (file)
@@ -151,13 +151,6 @@ void sym_xpt_done(struct sym_hcb *np, struct scsi_cmnd *cmd)
        cmd->scsi_done(cmd);
 }
 
-static void sym_xpt_done2(struct sym_hcb *np, struct scsi_cmnd *cmd, int cam_status)
-{
-       sym_set_cam_status(cmd, cam_status);
-       sym_xpt_done(np, cmd);
-}
-
-
 /*
  *  Tell the SCSI layer about a BUS RESET.
  */
@@ -324,15 +317,6 @@ static int sym_queue_command(struct sym_hcb *np, struct scsi_cmnd *cmd)
        int     order;
 
        /*
-        *  Minimal checkings, so that we will not 
-        *  go outside our tables.
-        */
-       if (sdev->id == np->myaddr) {
-               sym_xpt_done2(np, cmd, DID_NO_CONNECT);
-               return 0;
-       }
-
-       /*
         *  Retrieve the target descriptor.
         */
        tp = &np->target[sdev->id];
@@ -537,7 +521,7 @@ static int sym53c8xx_queue_command(struct scsi_cmnd *cmd,
        struct sym_ucmd *ucp = SYM_UCMD_PTR(cmd);
        int sts = 0;
 
-       cmd->scsi_done     = done;
+       cmd->scsi_done = done;
        memset(ucp, 0, sizeof(*ucp));
 
        /*