OSDN Git Service

staging: rtl8188eu: Use proper enum in rtl8188eu_config_rf_reg
authorNathan Chancellor <natechancellor@gmail.com>
Thu, 27 Sep 2018 00:32:01 +0000 (17:32 -0700)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 28 Sep 2018 12:30:52 +0000 (14:30 +0200)
Clang warns when an enumerated type is implicitly converted to another.

drivers/staging/rtl8188eu/hal/rf_cfg.c:180:25: warning: implicit
conversion from enumeration type 'enum rf90_radio_path' to different
enumeration type 'enum rf_radio_path' [-Wenum-conversion]
        rtl_rfreg_delay(adapt, RF90_PATH_A, addr | maskforphyset,
        ~~~~~~~~~~~~~~~        ^~~~~~~~~~~
1 warning generated.

Avoid this by using the equivalent value from the expected type,
rf_radio_path:

RF90_PATH_A = RF_PATH_A = 0

Link: https://github.com/ClangBuiltLinux/linux/issues/164
Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/rtl8188eu/hal/rf_cfg.c

index 0700d8b..02aeb12 100644 (file)
@@ -177,7 +177,7 @@ static void rtl8188e_config_rf_reg(struct adapter *adapt,
        u32 content = 0x1000; /*RF Content: radio_a_txt*/
        u32 maskforphyset = content & 0xE000;
 
-       rtl_rfreg_delay(adapt, RF90_PATH_A, addr | maskforphyset,
+       rtl_rfreg_delay(adapt, RF_PATH_A, addr | maskforphyset,
                        RFREG_OFFSET_MASK,
                        data);
 }