OSDN Git Service

Staging: rtl8192e: Use struct_size
authorFelix Schlepper <f3sch.git@outlook.com>
Fri, 24 Jun 2022 13:54:53 +0000 (15:54 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 27 Jun 2022 11:50:03 +0000 (13:50 +0200)
Using struct_size is encouraged because it is safer
than using sizeof and calculations by hand.

Signed-off-by: Felix Schlepper <f3sch.git@outlook.com>
Link: https://lore.kernel.org/r/54ea62a2b7628d3bdd5aa52df82c3e91704a2127.1656078068.git.f3sch.git@outlook.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/rtl8192e/rtllib_tx.c

index 37715af..f2ef32e 100644 (file)
@@ -205,8 +205,7 @@ static struct rtllib_txb *rtllib_alloc_txb(int nr_frags, int txb_size,
        struct rtllib_txb *txb;
        int i;
 
-       txb = kmalloc(sizeof(struct rtllib_txb) + (sizeof(u8 *) * nr_frags),
-                     gfp_mask);
+       txb = kmalloc(struct_size(txb, fragments, nr_frags), gfp_mask);
        if (!txb)
                return NULL;