OSDN Git Service

net: phy: at803x: remove probe and struct at803x_priv
authorOleksij Rempel <o.rempel@pengutronix.de>
Thu, 3 Oct 2019 08:21:13 +0000 (10:21 +0200)
committerDavid S. Miller <davem@davemloft.net>
Thu, 3 Oct 2019 19:27:06 +0000 (12:27 -0700)
struct at803x_priv is never used in this driver. So remove it
and the probe function allocating it.

Suggested-by: Heiner Kallweit <hkallweit1@gmail.com>
Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
Reviewed-by: Heiner Kallweit <hkallweit1@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/phy/at803x.c

index 7d778b8..ac29279 100644 (file)
@@ -63,10 +63,6 @@ MODULE_DESCRIPTION("Atheros 803x PHY driver");
 MODULE_AUTHOR("Matus Ujhelyi");
 MODULE_LICENSE("GPL");
 
-struct at803x_priv {
-       bool phy_reset:1;
-};
-
 struct at803x_context {
        u16 bmcr;
        u16 advertise;
@@ -232,20 +228,6 @@ static int at803x_resume(struct phy_device *phydev)
        return phy_modify(phydev, MII_BMCR, BMCR_PDOWN | BMCR_ISOLATE, 0);
 }
 
-static int at803x_probe(struct phy_device *phydev)
-{
-       struct device *dev = &phydev->mdio.dev;
-       struct at803x_priv *priv;
-
-       priv = devm_kzalloc(dev, sizeof(*priv), GFP_KERNEL);
-       if (!priv)
-               return -ENOMEM;
-
-       phydev->priv = priv;
-
-       return 0;
-}
-
 static int at803x_config_init(struct phy_device *phydev)
 {
        int ret;
@@ -364,7 +346,6 @@ static struct phy_driver at803x_driver[] = {
        .phy_id                 = ATH8035_PHY_ID,
        .name                   = "Atheros 8035 ethernet",
        .phy_id_mask            = AT803X_PHY_ID_MASK,
-       .probe                  = at803x_probe,
        .config_init            = at803x_config_init,
        .set_wol                = at803x_set_wol,
        .get_wol                = at803x_get_wol,
@@ -378,7 +359,6 @@ static struct phy_driver at803x_driver[] = {
        .phy_id                 = ATH8030_PHY_ID,
        .name                   = "Atheros 8030 ethernet",
        .phy_id_mask            = AT803X_PHY_ID_MASK,
-       .probe                  = at803x_probe,
        .config_init            = at803x_config_init,
        .link_change_notify     = at803x_link_change_notify,
        .set_wol                = at803x_set_wol,
@@ -393,7 +373,6 @@ static struct phy_driver at803x_driver[] = {
        .phy_id                 = ATH8031_PHY_ID,
        .name                   = "Atheros 8031 ethernet",
        .phy_id_mask            = AT803X_PHY_ID_MASK,
-       .probe                  = at803x_probe,
        .config_init            = at803x_config_init,
        .set_wol                = at803x_set_wol,
        .get_wol                = at803x_get_wol,