OSDN Git Service

thermal: intel: no need to check return value of debugfs_create functions
authorGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 13 Jun 2019 18:38:30 +0000 (20:38 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 18 Jun 2019 11:40:25 +0000 (13:40 +0200)
When calling debugfs functions, there is no need to ever check the
return value.  The function can work or not, but the code logic should
never do something different based on this.

Cc: Zhang Rui <rui.zhang@intel.com>
Cc: Eduardo Valentin <edubezval@gmail.com>
Cc: linux-pm@vger.kernel.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Reviewed-by: Daniel Lezcano <daniel.lezcano@linaro.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/thermal/intel/x86_pkg_temp_thermal.c

index 1ef937d..f0441ac 100644 (file)
@@ -87,29 +87,14 @@ static struct dentry *debugfs;
 static unsigned int pkg_interrupt_cnt;
 static unsigned int pkg_work_cnt;
 
-static int pkg_temp_debugfs_init(void)
+static void pkg_temp_debugfs_init(void)
 {
-       struct dentry *d;
-
        debugfs = debugfs_create_dir("pkg_temp_thermal", NULL);
-       if (!debugfs)
-               return -ENOENT;
-
-       d = debugfs_create_u32("pkg_thres_interrupt", S_IRUGO, debugfs,
-                              &pkg_interrupt_cnt);
-       if (!d)
-               goto err_out;
-
-       d = debugfs_create_u32("pkg_thres_work", S_IRUGO, debugfs,
-                              &pkg_work_cnt);
-       if (!d)
-               goto err_out;
 
-       return 0;
-
-err_out:
-       debugfs_remove_recursive(debugfs);
-       return -ENOENT;
+       debugfs_create_u32("pkg_thres_interrupt", S_IRUGO, debugfs,
+                          &pkg_interrupt_cnt);
+       debugfs_create_u32("pkg_thres_work", S_IRUGO, debugfs,
+                          &pkg_work_cnt);
 }
 
 /*