OSDN Git Service

usb: chipidea: udc: compress return logic into line
authorGustavo A. R. Silva <garsilva@embeddedor.com>
Mon, 10 Jul 2017 02:08:20 +0000 (21:08 -0500)
committerPeter Chen <peter.chen@nxp.com>
Wed, 19 Jul 2017 01:49:11 +0000 (09:49 +0800)
Simplify return logic to avoid unnecessary variable assignment.

This issue was detected using Coccinelle and the following
semantic patch:

@@
local idexpression ret;
expression e;
@@

-ret =
+return
     e;
-return ret;

Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
Signed-off-by: Peter Chen <peter.chen@nxp.com>
drivers/usb/chipidea/udc.c

index d68b125..6502c13 100644 (file)
@@ -944,7 +944,6 @@ isr_setup_status_complete(struct usb_ep *ep, struct usb_request *req)
  */
 static int isr_setup_status_phase(struct ci_hdrc *ci)
 {
-       int retval;
        struct ci_hw_ep *hwep;
 
        /*
@@ -960,9 +959,7 @@ static int isr_setup_status_phase(struct ci_hdrc *ci)
        ci->status->context = ci;
        ci->status->complete = isr_setup_status_complete;
 
-       retval = _ep_queue(&hwep->ep, ci->status, GFP_ATOMIC);
-
-       return retval;
+       return _ep_queue(&hwep->ep, ci->status, GFP_ATOMIC);
 }
 
 /**