* sigproc.cc (child_info::child_info): Set msv_count to non-zero

	value only on systems requiring it.

diff --git a/winsup/cygwin/ChangeLog b/winsup/cygwin/ChangeLog
index 86cd170..e6e2131 100644 (file)
--- a/winsup/cygwin/ChangeLog
+++ b/winsup/cygwin/ChangeLog
@@ -1,3 +1,8 @@
+2007-01-30  Corinna Vinschen  <corinna@vinschen.de>
+
+       * sigproc.cc (child_info::child_info): Set msv_count to non-zero
+       value only on systems requiring it.
+
 2007-01-28  Corinna Vinschen  <corinna@vinschen.de>
 
        * include/ftw.h: Include sys/cdefs.h.

diff --git a/winsup/cygwin/sigproc.cc b/winsup/cygwin/sigproc.cc
index a8d4a33..56f9622 100644 (file)
--- a/winsup/cygwin/sigproc.cc
+++ b/winsup/cygwin/sigproc.cc
@@ -804,14 +804,14 @@ child_info::child_info (unsigned in_cb, child_info_types chtype, bool need_subpr
      count doesn't result in trying to evaluate the content, so we do this
      really only for Vista 64 for now.
 
-     However, since this doesn't seem to harm normal windows operation we'll
-     just set it unconditionally until we hear complaints.
+     Note: It turns out that a non-zero value *does* harm operation on
+     XP 64 and 2K3 64 (Crash in CreateProcess call).
 
      The value is sizeof (child_info_*) / 5 which results in a count which
      covers the full datastructure, plus not more than 4 extra bytes.  This
      is ok as long as the child_info structure is cosily stored within a bigger
      datastructure. */
-  msv_count = in_cb / 5;
+  msv_count = wincap.needs_count_in_si_lpres2 () ? in_cb / 5 : 0;
 
   intro = PROC_MAGIC_GENERIC;
   magic = CHILD_INFO_MAGIC;