OSDN Git Service

AAPT: Dump status of required flag for uses-feature
authorAdam Lesinski <adamlesinski@google.com>
Mon, 8 Dec 2014 20:53:17 +0000 (12:53 -0800)
committerAdam Lesinski <adamlesinski@google.com>
Mon, 8 Dec 2014 23:54:12 +0000 (15:54 -0800)
Outside of a feature-group, the legacy uses-feature tag
has a boolean required flag that should be emitted in
dump badging.

Bug:17790999
Change-Id: I43023af00e9c9ed4bc35795c3a983fc719bf9b7a

tools/aapt/Command.cpp

index f5f70c5..d23b82e 100644 (file)
@@ -516,12 +516,10 @@ static void printFeatureGroup(const FeatureGroup& grp,
 
     const size_t numFeatures = grp.features.size();
     for (size_t i = 0; i < numFeatures; i++) {
-        if (!grp.features[i]) {
-            continue;
-        }
+        const bool required = grp.features[i];
 
         const String8& featureName = grp.features.keyAt(i);
-        printf("  uses-feature: name='%s'\n",
+        printf("  uses-feature%s: name='%s'\n", (required ? "" : "-not-required"),
                 ResTable::normalizeForOutput(featureName.string()).string());
     }
 
@@ -1844,7 +1842,7 @@ int doDump(Bundle* bundle)
                         }
                     }
 
-                   if (!grp.features.isEmpty()) {
+                    if (!grp.features.isEmpty()) {
                         printFeatureGroup(grp);
                     }
                 }