OSDN Git Service

drm/i915/params: use generics for parameter free
authorJani Nikula <jani.nikula@intel.com>
Wed, 18 Jan 2023 15:17:59 +0000 (17:17 +0200)
committerJani Nikula <jani.nikula@intel.com>
Wed, 25 Jan 2023 14:25:35 +0000 (16:25 +0200)
Replace the __builtin_strcmp() if ladder with generics.

Signed-off-by: Jani Nikula <jani.nikula@intel.com>
Reviewed-by: Luca Coelho <luciano.coelho@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20230118151800.3669913-3-jani.nikula@intel.com
drivers/gpu/drm/i915/i915_params.c

index f9d92d0..ade744c 100644 (file)
@@ -296,18 +296,21 @@ void i915_params_copy(struct i915_params *dest, const struct i915_params *src)
 #undef DUP
 }
 
-static __always_inline void free_param(const char *type, void *x)
+static void _param_free_charp(char **valp)
 {
-       if (!__builtin_strcmp(type, "char *")) {
-               kfree(*(void **)x);
-               *(void **)x = NULL;
-       }
+       kfree(*valp);
+       *valp = NULL;
 }
 
+#define _param_free(valp)                              \
+       _Generic(valp,                                  \
+                char **: _param_free_charp,            \
+                default: _param_nop)(valp)
+
 /* free the allocated members, *not* the passed in params itself */
 void i915_params_free(struct i915_params *params)
 {
-#define FREE(T, x, ...) free_param(#T, &params->x);
+#define FREE(T, x, ...) _param_free(&params->x);
        I915_PARAMS_FOR_EACH(FREE);
 #undef FREE
 }