OSDN Git Service

net: qed: Remove unneeded cast from memory allocation
authorAishwarya Ramakrishnan <aishwaryarj100@gmail.com>
Sun, 19 Apr 2020 16:29:17 +0000 (21:59 +0530)
committerDavid S. Miller <davem@davemloft.net>
Mon, 20 Apr 2020 19:23:06 +0000 (12:23 -0700)
Remove casting the values returned by memory allocation function.

Coccinelle emits WARNING: casting value returned by memory allocation
function to struct pointer is useless.

This issue was detected by using the Coccinelle.

Signed-off-by: Aishwarya Ramakrishnan <aishwaryarj100@gmail.com>
Acked-by: Michal KalderonĀ <michal.kalderon@marvell.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/qlogic/qed/qed_roce.c

index 37e7056..475b899 100644 (file)
@@ -736,9 +736,9 @@ static int qed_roce_sp_destroy_qp_responder(struct qed_hwfn *p_hwfn,
 
        p_ramrod = &p_ent->ramrod.roce_destroy_qp_resp;
 
-       p_ramrod_res = (struct roce_destroy_qp_resp_output_params *)
-           dma_alloc_coherent(&p_hwfn->cdev->pdev->dev, sizeof(*p_ramrod_res),
-                              &ramrod_res_phys, GFP_KERNEL);
+       p_ramrod_res = dma_alloc_coherent(&p_hwfn->cdev->pdev->dev,
+                                         sizeof(*p_ramrod_res),
+                                         &ramrod_res_phys, GFP_KERNEL);
 
        if (!p_ramrod_res) {
                rc = -ENOMEM;
@@ -872,10 +872,10 @@ int qed_roce_query_qp(struct qed_hwfn *p_hwfn,
        }
 
        /* Send a query responder ramrod to FW to get RQ-PSN and state */
-       p_resp_ramrod_res = (struct roce_query_qp_resp_output_params *)
-           dma_alloc_coherent(&p_hwfn->cdev->pdev->dev,
-                              sizeof(*p_resp_ramrod_res),
-                              &resp_ramrod_res_phys, GFP_KERNEL);
+       p_resp_ramrod_res =
+               dma_alloc_coherent(&p_hwfn->cdev->pdev->dev,
+                                  sizeof(*p_resp_ramrod_res),
+                                  &resp_ramrod_res_phys, GFP_KERNEL);
        if (!p_resp_ramrod_res) {
                DP_NOTICE(p_hwfn,
                          "qed query qp failed: cannot allocate memory (ramrod)\n");
@@ -920,8 +920,7 @@ int qed_roce_query_qp(struct qed_hwfn *p_hwfn,
        }
 
        /* Send a query requester ramrod to FW to get SQ-PSN and state */
-       p_req_ramrod_res = (struct roce_query_qp_req_output_params *)
-                          dma_alloc_coherent(&p_hwfn->cdev->pdev->dev,
+       p_req_ramrod_res = dma_alloc_coherent(&p_hwfn->cdev->pdev->dev,
                                              sizeof(*p_req_ramrod_res),
                                              &req_ramrod_res_phys,
                                              GFP_KERNEL);