OSDN Git Service

Document fence_class mess in drm_bo_setstatus_ioctl
authorKeith Packard <keithp@keithp.com>
Fri, 14 Dec 2007 20:49:22 +0000 (12:49 -0800)
committerKeith Packard <keithp@keithp.com>
Sat, 15 Dec 2007 20:10:42 +0000 (12:10 -0800)
drmBOSetStatus does not bother to set the fence_class parameter.
Fortunately, drm_bo_setstatus_ioctl doesn't end up using it as it
calls drm_bo_handle_validate with use_old_fence_class = 1.

linux-core/drm_bo.c

index aa613d7..1ce8697 100644 (file)
@@ -1851,6 +1851,12 @@ int drm_bo_setstatus_ioctl(struct drm_device *dev,
        if (ret)
                return ret;
 
+       /*
+        * validate the buffer. note that 'fence_class' will be unused
+        * as we pass use_old_fence_class=1 here. Note also that
+        * the libdrm API doesn't pass fence_class to the kernel,
+        * so it's a good thing it isn't used here.
+        */
        ret = drm_bo_handle_validate(file_priv, req->handle,
                                     req->flags,
                                     req->mask,