OSDN Git Service

staging: fsl-dpaa2/eth: Move print message
authorIoana Radulescu <ruxandra.radulescu@nxp.com>
Fri, 23 Mar 2018 13:44:06 +0000 (08:44 -0500)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 23 Mar 2018 15:01:56 +0000 (16:01 +0100)
Let the driver remove() function print an informative message
after it finishes removing the network interface, not at an
arbitrary point during cleanup.

Signed-off-by: Ioana Radulescu <ruxandra.radulescu@nxp.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/fsl-dpaa2/ethernet/dpaa2-eth.c

index beb5959..9fb88f2 100644 (file)
@@ -2550,7 +2550,6 @@ static int dpaa2_eth_remove(struct fsl_mc_device *ls_dev)
        priv = netdev_priv(net_dev);
 
        unregister_netdev(net_dev);
-       dev_info(net_dev->dev.parent, "Removed interface %s\n", net_dev->name);
 
        if (priv->do_link_poll)
                kthread_stop(priv->poll_thread);
@@ -2571,6 +2570,8 @@ static int dpaa2_eth_remove(struct fsl_mc_device *ls_dev)
        dev_set_drvdata(dev, NULL);
        free_netdev(net_dev);
 
+       dev_info(net_dev->dev.parent, "Removed interface %s\n", net_dev->name);
+
        return 0;
 }