OSDN Git Service

media: s5p_cec: decrement usage count if disabled
authorMauro Carvalho Chehab <mchehab+huawei@kernel.org>
Wed, 28 Apr 2021 07:38:56 +0000 (09:38 +0200)
committerMauro Carvalho Chehab <mchehab+huawei@kernel.org>
Mon, 10 May 2021 09:36:33 +0000 (11:36 +0200)
There's a bug at s5p_cec_adap_enable(): if called to
disable the device, it should call pm_runtime_put()
instead of pm_runtime_disable(), as the goal here is to
decrement the usage_count and not to disable PM runtime.

Reported-by: Sylwester Nawrocki <s.nawrocki@samsung.com>
Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Fixes: 1bcbf6f4b6b0 ("[media] cec: s5p-cec: Add s5p-cec driver")
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
drivers/media/cec/platform/s5p/s5p_cec.c

index 2a3e7ff..3c7c4c3 100644 (file)
@@ -51,7 +51,7 @@ static int s5p_cec_adap_enable(struct cec_adapter *adap, bool enable)
        } else {
                s5p_cec_mask_tx_interrupts(cec);
                s5p_cec_mask_rx_interrupts(cec);
-               pm_runtime_disable(cec->dev);
+               pm_runtime_put(cec->dev);
        }
 
        return 0;