OSDN Git Service

ASoC: rockchip: i2s-tdm: Remove call to rockchip_i2s_ch_to_io
authorColin Ian King <colin.king@canonical.com>
Fri, 8 Oct 2021 09:54:29 +0000 (10:54 +0100)
committerMark Brown <broonie@kernel.org>
Fri, 8 Oct 2021 16:22:51 +0000 (17:22 +0100)
The call to rockchip_i2s_ch_to_io is only useful for its return
value which is not being used. The function call also has no
side effects, the call is effectively useless and can be removed.

Addresses-Coverity: ("Useless call")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Message-Id: <20211008095430.62680-1-colin.king@canonical.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/rockchip/rockchip_i2s_tdm.c

index b08b150..cc5a2f9 100644 (file)
@@ -848,8 +848,6 @@ static int rockchip_i2s_io_multiplex(struct snd_pcm_substream *substream,
                                to_ch_num(val), usable_chs);
                        return -EINVAL;
                }
-
-               rockchip_i2s_ch_to_io(val, false);
        }
 
        val <<= i2s_tdm->soc_data->grf_shift;