OSDN Git Service

ASoC: SOF: Intel: MTL: Don't access EM2
authorPeter Ujfalusi <peter.ujfalusi@linux.intel.com>
Fri, 10 Mar 2023 13:34:54 +0000 (15:34 +0200)
committerMark Brown <broonie@kernel.org>
Fri, 10 Mar 2023 14:33:16 +0000 (14:33 +0000)
This reverts commit 2b5a30cafb2ef ("ASoC: SOF: Intel: MTL: Enable
DMI L1").

It came to our attention that the access to the EM2 register is restricted
to the DSP side on MTL compared to prior platforms.

Writing to it from the host side has no effect (negative or positive), it
is better to remove the code to not cause confusion and wrong impression.

Signed-off-by: Peter Ujfalusi <peter.ujfalusi@linux.intel.com>
Link: https://lore.kernel.org/r/20230310133454.15362-1-peter.ujfalusi@linux.intel.com
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/sof/intel/mtl.c
sound/soc/sof/intel/mtl.h

index 8f0ed1c..58959c2 100644 (file)
@@ -280,9 +280,6 @@ static int mtl_dsp_post_fw_run(struct snd_sof_dev *sdev)
        }
 
        hda_sdw_int_enable(sdev, true);
-
-       /* enable DMI L1 */
-       snd_sof_dsp_update_bits(sdev, HDA_DSP_HDA_BAR, MTL_EM2, MTL_EM2_L1SEN, MTL_EM2_L1SEN);
        return 0;
 }
 
index ddc0530..26418fb 100644 (file)
@@ -28,8 +28,6 @@
 #define MTL_HFINTIPPTR_PTR_MASK                GENMASK(20, 0)
 
 #define MTL_HDA_VS_D0I3C               0x1D4A
-#define MTL_EM2                                0x1c44
-#define MTL_EM2_L1SEN                  BIT(13)
 
 #define MTL_DSP2CXCAP_PRIMARY_CORE     0x178D00
 #define MTL_DSP2CXCTL_PRIMARY_CORE     0x178D04