OSDN Git Service

drm: bridge: icn6211: Set SYS_CTRL_1 to value used in examples
authorMarek Vasut <marex@denx.de>
Thu, 31 Mar 2022 15:05:05 +0000 (17:05 +0200)
committerRobert Foss <robert.foss@linaro.org>
Thu, 31 Mar 2022 15:20:41 +0000 (17:20 +0200)
Both example code [1], [2] as well as one provided by custom panel vendor
set register SYS_CTRL_1 to 0x88. What exactly does the value mean is unknown
due to unavailable datasheet. Align this register value with example code.

[1] https://github.com/rockchip-linux/kernel/blob/develop-4.19/drivers/gpu/drm/bridge/icn6211.c
[2] https://github.com/tdjastrzebski/ICN6211-Configurator

Acked-by: Maxime Ripard <maxime@cerno.tech>
Signed-off-by: Marek Vasut <marex@denx.de>
Cc: Jagan Teki <jagan@amarulasolutions.com>
Cc: Maxime Ripard <maxime@cerno.tech>
Cc: Robert Foss <robert.foss@linaro.org>
Cc: Sam Ravnborg <sam@ravnborg.org>
Cc: Thomas Zimmermann <tzimmermann@suse.de>
To: dri-devel@lists.freedesktop.org
Signed-off-by: Robert Foss <robert.foss@linaro.org>
Link: https://patchwork.freedesktop.org/patch/msgid/20220331150509.9838-8-marex@denx.de
drivers/gpu/drm/bridge/chipone-icn6211.c

index 4d6baef..b2faad4 100644 (file)
@@ -308,7 +308,7 @@ static void chipone_atomic_enable(struct drm_bridge *bridge,
        chipone_configure_pll(icn, mode);
 
        ICN6211_DSI(icn, SYS_CTRL(0), 0x40);
-       ICN6211_DSI(icn, SYS_CTRL(1), 0x98);
+       ICN6211_DSI(icn, SYS_CTRL(1), 0x88);
 
        /* icn6211 specific sequence */
        ICN6211_DSI(icn, MIPI_FORCE_0, 0x20);