OSDN Git Service

[media] dib0090: Fix a warning at dib0090_set_EFUSE
authorMauro Carvalho Chehab <mchehab@redhat.com>
Thu, 25 Apr 2013 18:30:40 +0000 (15:30 -0300)
committerMauro Carvalho Chehab <mchehab@redhat.com>
Thu, 25 Apr 2013 19:06:55 +0000 (16:06 -0300)
The check if the values for c, h and n are within the range is
always true, as, if one of this values is out of range, the
previous "if" clauses will default to a value within the
range.

That fixes the following warning:

drivers/media/dvb-frontends/dib0090.c: In function 'dib0090_set_EFUSE':
drivers/media/dvb-frontends/dib0090.c:1545:5: warning: comparison is always true due to limited range of data type [-Wtype-limits]

and makes the code easier to read.

Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
drivers/media/dvb-frontends/dib0090.c

index f9916b8..3ee22ff 100644 (file)
@@ -1540,13 +1540,9 @@ static void dib0090_set_EFUSE(struct dib0090_state *state)
                if ((n >= POLY_MAX) || (n <= POLY_MIN))
                        n = 3;
 
-               if ((c >= CAP_VALUE_MIN) && (c <= CAP_VALUE_MAX)
-                               && (h >= HR_MIN) && (h <= HR_MAX)
-                               && (n >= POLY_MIN) && (n <= POLY_MAX)) {
-                       dib0090_write_reg(state, 0x13, (h << 10));
-                       e2 = (n << 11) | ((h >> 2)<<6) | c;
-                       dib0090_write_reg(state, 0x2, e2); /* Load the BB_2 */
-               }
+               dib0090_write_reg(state, 0x13, (h << 10));
+               e2 = (n << 11) | ((h >> 2)<<6) | c;
+               dib0090_write_reg(state, 0x2, e2); /* Load the BB_2 */
        }
 }