OSDN Git Service

phy: ti: Fix missing of_node_put in ti_pipe3_get_sysctrl()
authorLv Ruyi <lv.ruyi@zte.com.cn>
Fri, 8 Apr 2022 09:56:17 +0000 (09:56 +0000)
committerVinod Koul <vkoul@kernel.org>
Mon, 11 Apr 2022 17:15:31 +0000 (22:45 +0530)
of_parse_phandle() returns node pointer with refcount incremented, use
of_node_put() on it to decrease refcount when done.

Reported-by: Zeal Robot <zealci@zte.com.cn>
Signed-off-by: Lv Ruyi <lv.ruyi@zte.com.cn>
Link: https://lore.kernel.org/r/20220408095617.2495234-1-lv.ruyi@zte.com.cn
Signed-off-by: Vinod Koul <vkoul@kernel.org>
drivers/phy/ti/phy-ti-pipe3.c

index 2cbc91e..f502c36 100644 (file)
@@ -696,6 +696,7 @@ static int ti_pipe3_get_sysctrl(struct ti_pipe3 *phy)
                }
 
                control_pdev = of_find_device_by_node(control_node);
+               of_node_put(control_node);
                if (!control_pdev) {
                        dev_err(dev, "Failed to get control device\n");
                        return -EINVAL;