OSDN Git Service

i2c: mpc: fix PORDEVSR2 mask for MPC8533/44
authorArseny Solokha <asolokha@kb.kras.ru>
Thu, 7 Dec 2017 10:20:02 +0000 (17:20 +0700)
committerWolfram Sang <wsa@the-dreams.de>
Mon, 15 Jan 2018 18:16:14 +0000 (19:16 +0100)
According to the reference manuals for the corresponding SoCs, SEC
frequency ratio configuration is indicated by bit 26 of the POR Device
Status Register 2. Consequently, SEC_CFG bit should be tested by mask 0x20,
not 0x80. Testing the wrong bit leads to selection of wrong I2C clock
prescaler on those SoCs.

Signed-off-by: Arseny Solokha <asolokha@kb.kras.ru>
Signed-off-by: Wolfram Sang <wsa@the-dreams.de>
drivers/i2c/busses/i2c-mpc.c

index 648a5af..aac0ec6 100644 (file)
@@ -332,14 +332,18 @@ static u32 mpc_i2c_get_sec_cfg_8xxx(void)
                if (prop) {
                        /*
                         * Map and check POR Device Status Register 2
-                        * (PORDEVSR2) at 0xE0014
+                        * (PORDEVSR2) at 0xE0014. Note than while MPC8533
+                        * and MPC8544 indicate SEC frequency ratio
+                        * configuration as bit 26 in PORDEVSR2, other MPC8xxx
+                        * parts may store it differently or may not have it
+                        * at all.
                         */
                        reg = ioremap(get_immrbase() + *prop + 0x14, 0x4);
                        if (!reg)
                                printk(KERN_ERR
                                       "Error: couldn't map PORDEVSR2\n");
                        else
-                               val = in_be32(reg) & 0x00000080; /* sec-cfg */
+                               val = in_be32(reg) & 0x00000020; /* sec-cfg */
                        iounmap(reg);
                }
        }