OSDN Git Service

isdn/hisax: amd7930_fn: Remove unnecessary parentheses
authorNathan Chancellor <natechancellor@gmail.com>
Mon, 8 Oct 2018 22:59:05 +0000 (15:59 -0700)
committerDavid S. Miller <davem@davemloft.net>
Thu, 11 Oct 2018 05:28:50 +0000 (22:28 -0700)
Clang warns when multiple sets of parentheses are used for a single
conditional statement.

drivers/isdn/hisax/amd7930_fn.c:628:32: warning: equality comparison
with extraneous parentheses [-Wparentheses-equality]
                if ((cs->dc.amd7930.ph_state == 8)) {
                     ~~~~~~~~~~~~~~~~~~~~~~~~^~~~
drivers/isdn/hisax/amd7930_fn.c:628:32: note: remove extraneous
parentheses around the comparison to silence this warning
                if ((cs->dc.amd7930.ph_state == 8)) {
                    ~                        ^   ~
drivers/isdn/hisax/amd7930_fn.c:628:32: note: use '=' to turn this
equality comparison into an assignment
                if ((cs->dc.amd7930.ph_state == 8)) {
                                             ^~
                                             =
1 warning generated.

Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/isdn/hisax/amd7930_fn.c

index 77debda..6c33636 100644 (file)
@@ -625,7 +625,7 @@ Amd7930_l1hw(struct PStack *st, int pr, void *arg)
                break;
        case (HW_RESET | REQUEST):
                spin_lock_irqsave(&cs->lock, flags);
-               if ((cs->dc.amd7930.ph_state == 8)) {
+               if (cs->dc.amd7930.ph_state == 8) {
                        /* b-channels off, PH-AR cleared
                         * change to F3 */
                        Amd7930_ph_command(cs, 0x20, "HW_RESET REQUEST"); //LMR1 bit 5