OSDN Git Service

spi: spi-fsl-spi: Return an error code in fsl_spi_do_one_msg()
authorFabio Estevam <fabio.estevam@freescale.com>
Thu, 4 Dec 2014 13:15:47 +0000 (11:15 -0200)
committerMark Brown <broonie@kernel.org>
Thu, 4 Dec 2014 22:43:56 +0000 (22:43 +0000)
Since commit c592becbe704127 ("spi: fsl-(e)spi: migrate to generic master
queueing") the function fsl_spi_do_one_msg() is not void anymore, so return
an error code to avoid the following buid warning:

   drivers/spi/spi-fsl-spi.c: In function 'fsl_spi_do_one_msg':
>> drivers/spi/spi-fsl-spi.c:374:4: warning: 'return' with no value, in function returning non-void [-Wreturn-type]
       return;
       ^

Reported-by: kbuild test robot <fengguang.wu@intel.com>
Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
drivers/spi/spi-fsl-spi.c

index 6b94428..5e02c1f 100644 (file)
@@ -371,7 +371,7 @@ static int fsl_spi_do_one_msg(struct spi_master *master,
                        status = -EINVAL;
                        dev_err(&spi->dev,
                                "bits_per_word/speed_hz should be same for the same SPI transfer\n");
-                       return;
+                       return -EINVAL;
                }
        }