OSDN Git Service

iwlwifi: mvm: reduce WARN_ON() in TX status path
authorJohannes Berg <johannes.berg@intel.com>
Sun, 17 Oct 2021 13:26:04 +0000 (16:26 +0300)
committerLuca Coelho <luciano.coelho@intel.com>
Fri, 22 Oct 2021 07:49:03 +0000 (10:49 +0300)
Evidently, it's possible to hit this issue, so reduce the
noise from it by just having it print a (rate-limited)
message instead. We don't really know yet why we hit it,
but there's no value in having a WARN_ON() here.

Signed-off-by: Johannes Berg <johannes.berg@intel.com>
Signed-off-by: Luca Coelho <luciano.coelho@intel.com>
Link: https://lore.kernel.org/r/iwlwifi.20211017162352.8d503387b523.Id2c82d023df5128e553b28c935d30df4d9411917@changeid
Signed-off-by: Luca Coelho <luciano.coelho@intel.com>
drivers/net/wireless/intel/iwlwifi/mvm/tx.c

index 4cc543f..bdd4ee4 100644 (file)
@@ -1505,7 +1505,9 @@ static void iwl_mvm_rx_tx_cmd_single(struct iwl_mvm *mvm,
                        /* the FW should have stopped the queue and not
                         * return this status
                         */
-                       WARN_ON(1);
+                       IWL_ERR_LIMIT(mvm,
+                                     "FW reported TX filtered, status=0x%x, FC=0x%x\n",
+                                     status, le16_to_cpu(hdr->frame_control));
                        info->flags |= IEEE80211_TX_STAT_TX_FILTERED;
                        break;
                default: