OSDN Git Service

Don't show empty tag stats for unprivileged uids
authorMohamad Ayyash <mkayyash@google.com>
Wed, 11 May 2016 20:18:35 +0000 (13:18 -0700)
committerGerrit - the friendly Code Review server <code-review@localhost>
Mon, 31 Oct 2016 18:26:04 +0000 (11:26 -0700)
BUG: 27577101
BUG: 27532522
Signed-off-by: Mohamad Ayyash <mkayyash@google.com>
Git-repo: https://android.googlesource.com/kernel/common.git
Git-commit: d85e322ff3bc8d7aa872ad12df6427dd236e540a
Signed-off-by: Ravi Kumar Siddojigari <rsiddoji@codeaurora.org>
Change-Id: Ia706e7184ab31c5e4e3bb2668a1ab7660ca3c6ce

net/netfilter/xt_qtaguid.c

index dca5cac..ececa65 100644 (file)
@@ -2536,8 +2536,7 @@ static int pp_stats_line(struct seq_file *m, struct tag_stat *ts_entry,
        uid_t stat_uid = get_uid_from_tag(tag);
        struct proc_print_info *ppi = m->private;
        /* Detailed tags are not available to everybody */
-       if (get_atag_from_tag(tag) && !can_read_other_uid_stats(
-                                               make_kuid(&init_user_ns,stat_uid))) {
+       if (!can_read_other_uid_stats(make_kuid(&init_user_ns,stat_uid))) {
                CT_DEBUG("qtaguid: stats line: "
                         "%s 0x%llx %u: insufficient priv "
                         "from pid=%u tgid=%u uid=%u stats.gid=%u\n",