OSDN Git Service
(root)
/
uclinux-h8
/
linux.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
81a15b9
)
drm/mcde: dsi: Fix return value check in mcde_dsi_bind()
author
Wei Yongjun
<weiyongjun1@huawei.com>
Thu, 30 Apr 2020 07:31:45 +0000
(07:31 +0000)
committer
Linus Walleij
<linus.walleij@linaro.org>
Tue, 12 May 2020 11:48:24 +0000
(13:48 +0200)
The of_drm_find_bridge() function returns NULL on error, it doesn't return
error pointers so this check doesn't work.
Fixes:
5fc537bfd000
("drm/mcde: Add new driver for ST-Ericsson MCDE")
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
Link:
https://patchwork.freedesktop.org/patch/msgid/20200430073145.52321-1-weiyongjun1@huawei.com
drivers/gpu/drm/mcde/mcde_dsi.c
patch
|
blob
|
history
diff --git
a/drivers/gpu/drm/mcde/mcde_dsi.c
b/drivers/gpu/drm/mcde/mcde_dsi.c
index
1baa232
..
f303369
100644
(file)
--- a/
drivers/gpu/drm/mcde/mcde_dsi.c
+++ b/
drivers/gpu/drm/mcde/mcde_dsi.c
@@
-1073,10
+1073,9
@@
static int mcde_dsi_bind(struct device *dev, struct device *master,
panel = NULL;
bridge = of_drm_find_bridge(child);
- if (IS_ERR(bridge)) {
- dev_err(dev, "failed to find bridge (%ld)\n",
- PTR_ERR(bridge));
- return PTR_ERR(bridge);
+ if (!bridge) {
+ dev_err(dev, "failed to find bridge\n");
+ return -EINVAL;
}
}
}