OSDN Git Service

thermal: int340x_thermal: Use sysfs_emit_at() instead of scnprintf()
authorye xingchen <ye.xingchen@zte.com.cn>
Tue, 17 Jan 2023 02:42:17 +0000 (10:42 +0800)
committerRafael J. Wysocki <rafael.j.wysocki@intel.com>
Fri, 20 Jan 2023 16:59:35 +0000 (17:59 +0100)
Follow the advice of the Documentation/filesystems/sysfs.rst that show()
should only use sysfs_emit() or sysfs_emit_at() when formatting the
value to be returned to user space.

Signed-off-by: ye xingchen <ye.xingchen@zte.com.cn>
[ rjw: Subject rewrite ]
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
drivers/thermal/intel/int340x_thermal/int3400_thermal.c

index db8a6f6..c1fc4a7 100644 (file)
@@ -130,10 +130,7 @@ static ssize_t available_uuids_show(struct device *dev,
 
        for (i = 0; i < INT3400_THERMAL_MAXIMUM_UUID; i++) {
                if (priv->uuid_bitmap & (1 << i))
-                       length += scnprintf(&buf[length],
-                                           PAGE_SIZE - length,
-                                           "%s\n",
-                                           int3400_thermal_uuids[i]);
+                       length += sysfs_emit_at(buf, length, int3400_thermal_uuids[i]);
        }
 
        return length;
@@ -151,10 +148,7 @@ static ssize_t current_uuid_show(struct device *dev,
 
        for (i = 0; i <= INT3400_THERMAL_CRITICAL; i++) {
                if (priv->os_uuid_mask & BIT(i))
-                       length += scnprintf(&buf[length],
-                                           PAGE_SIZE - length,
-                                           "%s\n",
-                                           int3400_thermal_uuids[i]);
+                       length += sysfs_emit_at(buf, length, int3400_thermal_uuids[i]);
        }
 
        if (length)