OSDN Git Service

staging: ks7010: move comparison to right hand side
authorTobin C. Harding <me@tobin.cc>
Mon, 13 Mar 2017 22:54:05 +0000 (09:54 +1100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 14 Mar 2017 00:08:15 +0000 (08:08 +0800)
Checkpatch emits WARNING: Comparisons should place the constant on the
right side of the test.

Move constant to right hand side of test, modify operator to ensure
logic is maintained.

Signed-off-by: Tobin C. Harding <me@tobin.cc>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/ks7010/ks_wlan_net.c

index 648170d..7820440 100644 (file)
@@ -2044,7 +2044,7 @@ static int ks_wlan_set_pmksa(struct net_device *dev,
                                }
                        }
                        if (ptr == &priv->pmklist.head) {       /* not find address. */
-                               if (PMK_LIST_MAX > priv->pmklist.size) {        /* new cache data */
+                               if (priv->pmklist.size <= PMK_LIST_MAX) {       /* new cache data */
                                        for (i = 0; i < PMK_LIST_MAX; i++) {
                                                pmk = &priv->pmklist.pmk[i];
                                                if (!memcmp