OSDN Git Service

media: mt9m001: set all mbus format field when G_FMT and S_FMT ioctls
authorAkinobu Mita <akinobu.mita@gmail.com>
Tue, 8 Jan 2019 14:51:50 +0000 (12:51 -0200)
committerMauro Carvalho Chehab <mchehab+samsung@kernel.org>
Fri, 25 Jan 2019 12:59:51 +0000 (10:59 -0200)
This driver doesn't set all members of mbus format field when the
VIDIOC_SUBDEV_{S,G}_FMT ioctls are called.

This is detected by v4l2-compliance.

Cc: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
Signed-off-by: Akinobu Mita <akinobu.mita@gmail.com>
Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>
drivers/media/i2c/mt9m001.c

index eac10ff..4b23fde 100644 (file)
@@ -340,6 +340,9 @@ static int mt9m001_get_fmt(struct v4l2_subdev *sd,
        mf->code        = mt9m001->fmt->code;
        mf->colorspace  = mt9m001->fmt->colorspace;
        mf->field       = V4L2_FIELD_NONE;
+       mf->ycbcr_enc   = V4L2_YCBCR_ENC_DEFAULT;
+       mf->quantization = V4L2_QUANTIZATION_DEFAULT;
+       mf->xfer_func   = V4L2_XFER_FUNC_DEFAULT;
 
        return 0;
 }
@@ -400,6 +403,10 @@ static int mt9m001_set_fmt(struct v4l2_subdev *sd,
        }
 
        mf->colorspace  = fmt->colorspace;
+       mf->field       = V4L2_FIELD_NONE;
+       mf->ycbcr_enc   = V4L2_YCBCR_ENC_DEFAULT;
+       mf->quantization = V4L2_QUANTIZATION_DEFAULT;
+       mf->xfer_func   = V4L2_XFER_FUNC_DEFAULT;
 
        if (format->which == V4L2_SUBDEV_FORMAT_ACTIVE)
                return mt9m001_s_fmt(sd, fmt, mf);