OSDN Git Service

l2tpv3: fix possible double free
authorzhanghailiang <zhang.zhanghailiang@huawei.com>
Fri, 14 Nov 2014 01:39:23 +0000 (09:39 +0800)
committerPaolo Bonzini <pbonzini@redhat.com>
Fri, 14 Nov 2014 11:16:24 +0000 (12:16 +0100)
freeaddrinfo(result) does not assign result = NULL, after frees it.
There will be a double free when it goes error case.
It is reported by covertiy.

Reviewed-by: Gonglei <arei.gonglei@huawei.com>
Cc: qemu-stable@nongnu.org
Signed-off-by: zhanghailiang <zhang.zhanghailiang@huawei.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
net/l2tpv3.c

index 528d95b..65db5ef 100644 (file)
@@ -660,7 +660,6 @@ int net_init_l2tpv3(const NetClientOptions *opts,
     if (fd == -1) {
         fd = -errno;
         error_report("l2tpv3_open : socket creation failed, errno = %d", -fd);
-        freeaddrinfo(result);
         goto outerr;
     }
     if (bind(fd, (struct sockaddr *) result->ai_addr, result->ai_addrlen)) {